Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to be compatible with ESLint v9 #357

Merged
merged 6 commits into from
May 3, 2024
Merged

Conversation

TylerVigario
Copy link
Contributor

This needs a lookover by someone with more in-depth knowledge of this package. I got it working just fine with a local project.

Closes #356

@sindresorhus
Copy link
Member

CI is failing

@TylerVigario
Copy link
Contributor Author

TylerVigario commented Apr 27, 2024

It seems we are not using "object" style formatting with our rules - https://github.com/eslint-community/eslint-plugin-eslint-plugin/blob/main/docs/rules/prefer-object-rule.md

However, I am not a fluent ESLint (plugin) developer, so corrections may take a while or never arrive.

EDIT: This also increases the Node version requirement, which should be reviewed more intently as it no longer supports the Node versions our CI uses.

@sindresorhus
Copy link
Member

Feel free to bump the requirement to Node.js 18.18

@sindresorhus sindresorhus merged commit b5561e4 into avajs:main May 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to eslint v9
2 participants