#355: dependencies with undefined value will not do http request #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex-cory , can you please review this PR #355 |
krishnasaga
reviewed
Dec 4, 2022
| Array.isArray(dependencies) && | ||
| (dependencies.length === 0 || | ||
| dependencies.filter((d) => !isEmpty(d)).length > 0) | ||
| ) { |
There was a problem hiding this comment.
@fkrafi are there any unit tests/tests relevant to this feature ? for the newly added/fixed one and existing functionality
So it will be easy to review ?
fkrafi
force-pushed
the
feature/fetch_is_called_in_spite_of_conditional_variables_are_undefined_#355
branch
from
307b5ee
to
a0e2979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.