Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download binaries from vim #920

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

abitrolly
Copy link

:LanguageClientInstallBinaries makes it easy to download or refresh languageclient. This is my first time writing vimscript and I just wrapped provided install.sh.

@autozimu
Copy link
Owner

autozimu commented Dec 2, 2019

What are the benefits of providing this extra command than relying on plugin manager like plug or dein to do the work automatically? If the user needs to do the download one time occasionally, it should be easy enough to fire off the command in terminal.

@abitrolly
Copy link
Author

@autozimu I don't use plugin managers with Vim 8, because it is able to discover and run plugin itself. The ability to download/refresh binaries is a convenience feature I used to in vim-go. Instead of directing users to RTFM in case of missing binaries, it offers a quick way to fix problem with one command.

@abitrolly abitrolly changed the base branch from next to dev March 11, 2021 18:57
autoload/LanguageClient.vim:599:1: Use the abort attribute for functions in autoload (see Google VimScript Style Guide (Functions))
autoload/LanguageClient.vim:605:13: Prefer single quoted strings (see Google VimScript Style Guide (Strings))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants