Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517, #915.
I don't know that I'm completely convinced by this myself:
:tag
) that doesn't work; because the things in the tag stack aren't actually tags so they can't be re-discovered that wayI've also done a round of cargo updates, though #892 seems to commit this project to being stuck with an old
jsonrpc-core
.Re #892 I'd suggest that if the Sorbet developers think that it's OK to add random fields to a JSON-RPC response, they should make that case at
json-rpc
core. paritytech/jsonrpc#448 looks to be where the conversation happened. (Else fix their language server not to do that.)