Feature debian 12 install script #1109
Draft
+1,131
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to install on Bare Metal in a Debian 12 Installation." Issue automatic-ripping-machine#1070 Create Script and function "Has_Sudo_Privileges()"
…he user does not have Sudo privileges.
…erve Global Variable values outside of functions. Added function to create arm Group.
Need to seperate it into more readable functions.
Comment Code for legibility.
Added Building and Installing of MakeMKV. Fixed a bug where the script would not complete if run as sudo.
Create function to test for the availability of the contrib package, if that test fails, exit the script.
…' into feature_Debian-12-Install-Script
… to checkout the repository, if existing, at the latest ARM Release.
…' into feature_Debian-12-Install-Script
1. This installation method is unsupported. 2. MakeMKV is in Beta and free to use while in Beta, and provide a link to MakeMKV purchase page. 3. Provide a link to the ARM MIT licence
…' into feature_Debian-12-Install-Script
GitHub Worklow was updating the version number automatically. Returned the Version Number to what it should be after disabling the GitHub Workflow.
…install the Python Requirements.
A new Udev Rules file. A new Amr.service file. A new arm_venv_wrapper.sh file Updated Debian12Installer.sh file to use the newly created files. Also added a testing flag to pull from testing repo and not production repo.
…system to /lib/systemd/system
…fault sudo is not installed in the Proxmox LXC Debian 12 container image...) Added a stub function for running the post-install setup UI
…uplication of code that could lead to hard to find errors and bugs. Added verification for the installation of the sudo package. Added verification for the installation of the lsb-release package and the ability for the script to install it if missing. Succesfully tested in a Proxmox LXC container enviroment.
…DO script call. (The ability to call the script with or without SUDO... Now the script needs to be called with SUDO or as root)
… yet to be made...
…' into feature_Debian-12-Install-Script
…due to user error (fail to enter match the password 3 times). The user and group arm would be created but no password would be set on the account. Now if the user fails to enter a password, the newly crated account is deleted. if the arm user account is pre-existing, give the user the opportunity to change it's password.
…passed to the script. Now the script exits with and error if the fork or tag was not found.
…ub repo of a prior installation to deleting any existing /opt/arm directory and clonning a fresh repository from the chosen fork and tag. Give the user the option to decline to proceed. Copy any existing config files to backups.
…ping the apt update call to just one.
More testing is required to attempt to test more variables.
…d OMV. This wiki entry is still a draft.
…' into feature_Debian-12-Install-Script
…' into feature_Debian-12-Install-Script
…' into feature_Debian-12-Install-Script
If innactive, warn the user that proceeding is not recommended but allow for the user to continue the process. Moved test for presence of /opt/amr directory ealier, before any installation is completed, to allow the user to abandon installation earlier and only make minimal changes to the system. Added link to MakeMKV-Info wiki page.
- Added Pre-Installation Steps - Added 2 new error codes - Modified the formatting of the Note at the top of the page regarding the deprecated nature of this installation method.
|
I apologize for the Unverified commits, I had some configuration issues with my PyCharm installations. I can verify that each of these commits was indeed made by myself. |
|
I'll test this when I get a chance |
|
I encountered a problem when I tried to use it in a Proxmox Container, I'm going to work to fix it and set this pull ready for review when I have a fix for it. I am also going to build HandBrake from source to use the latest version, as that too caused me an issue when trying to use Hardware Acceleration. Sorry for the delay. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1070
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The testing methodology unfortunately is not automated. To complete these tests I had to create and destroy VMs on Proxmox numerous times. For each check that the script performs, I have tested on Debian 12. These include (but are not limited to)
Tested installation on these Linux Distributions
Checklist:
Changelog:
Include the details of changes made here
Logs
Not applicable