Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries] Use AutoGluon forks of Chronos models #4198

Merged
merged 1 commit into from
May 17, 2024

Conversation

shchur
Copy link
Collaborator

@shchur shchur commented May 14, 2024

Description of changes:

  • Use autogluon/chronos-t5-* path to load Chronos models

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shchur shchur requested a review from canerturkmen May 14, 2024 16:07
@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run
pyarrow==16.0.0 pyarrow==16.1.0
pyarrow==16.0.0 pyarrow==16.1.0

Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, looks good otherwise. Thanks!!

"""
return MODEL_CONFIGS.get(self.model_path, {})
model_name = str(self.model_path).split("/")[-1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the intention is to make it work also on local paths, this will not work for Windows.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention is to make this work with both amazon/chronos-t5-* and autogluon/chronos-t5-* paths, so should be fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then note that this will now include local paths on *nix that are named according to the amazon-t5-* convention, but not on windows.

Copy link

Job PR-4198-6948866 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4198/6948866/index.html

@shchur shchur merged commit 8e6c647 into autogluon:master May 17, 2024
29 checks passed
@shchur shchur deleted the use-ag-chronos-forks branch May 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants