-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[timeseries] bump statsforecast version #4194
base: master
Are you sure you want to change the base?
Conversation
|
Job PR-4194-9a7c3f5 is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Left a few comments.
# otherwise model will crash | ||
if len(time_series) < 5: | ||
# AutoCES does not handle "tiny" datasets, fall back to naive | ||
return np.full(self.prediction_length, time_series.values[-1]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this problem still there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only found this relevant change so I'll assume it's still there:
Nixtla/statsforecast@93483aa
timeseries/src/autogluon/timeseries/models/local/statsforecast.py
Outdated
Show resolved
Hide resolved
@@ -32,10 +32,8 @@ | |||
"accelerate", # version range defined in `core/_setup_utils.py` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait until v1.1.1 is released before merging this PR?
|
Job PR-4194-40a4cfb is done. |
Issue #, if available:
Description of changes:
Do not merge until after v1.1.1 release
Bump StatsForecast version to v1.7.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.