Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): use new grid #7248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Apr 27, 2024

Summary by CodeRabbit

  • Refactor
    • Updated Grid component usage across various components and views to enhance layout consistency and performance.
  • New Features
    • Improved layout components in areas including brand representation, privacy policies, login processes, and password reset functionalities.

@authelia
Copy link

authelia bot commented Apr 27, 2024

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:refactor-web-grids
  • docker pull ghcr.io/authelia/authelia:refactor-web-grids

Copy link
Contributor

coderabbitai bot commented Apr 27, 2024

Warning

Rate limit exceeded

@james-d-elliott has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 57 minutes and 42 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between bc224da and 43f4934.

Walkthrough

The recent updates across various components primarily involve transitioning from the stable Grid component of @mui/material to the experimental Unstable_Grid2/Grid2. This shift affects import statements and the usage of the Grid component, notably removing the item prop in many instances. This change appears to streamline component usage and possibly leverage improvements or new features in the experimental Grid version.

Changes

File Path Change Summary
.../Brand.tsx, .../PrivacyPolicyDrawer.tsx, .../LoginLayout.tsx, .../MinimalLayout.tsx, .../BaseLoadingPage.tsx, .../AuthenticatedView.tsx, .../ConsentView.tsx, .../FirstFactorForm.tsx, .../ResetPasswordStep1.tsx, .../ResetPasswordStep2.tsx Transitioned from using Grid from @mui/material to Unstable_Grid2/Grid2. Adjustments made to remove the item prop within Grid usage across various components.
.../DeviceSelectionContainer.tsx, .../MethodSelectionDialog.tsx, .../SecondFactorForm.tsx Updated Grid import to Unstable_Grid2/Grid2 in these components. Removed item prop from Grid usage.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

web/src/layouts/LoginLayout.tsx Outdated Show resolved Hide resolved
web/src/layouts/MinimalLayout.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

web/src/layouts/MinimalLayout.tsx Outdated Show resolved Hide resolved
web/src/layouts/LoginLayout.tsx Outdated Show resolved Hide resolved
web/src/views/LoginPortal/FirstFactor/FirstFactorForm.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.68%. Comparing base (1870378) to head (43f4934).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7248      +/-   ##
==========================================
- Coverage   73.68%   73.68%   -0.01%     
==========================================
  Files         346      346              
  Lines       30022    30022              
  Branches      839      839              
==========================================
- Hits        22123    22121       -2     
- Misses       7026     7028       +2     
  Partials      873      873              
Flag Coverage Δ
backend 74.55% <ø> (-0.02%) ⬇️
frontend 66.00% <57.14%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/components/Brand.tsx 80.00% <ø> (ø)
web/src/components/PrivacyPolicyDrawer.tsx 100.00% <ø> (ø)
web/src/layouts/MinimalLayout.tsx 85.71% <100.00%> (ø)
web/src/views/LoadingPage/BaseLoadingPage.tsx 100.00% <ø> (ø)
...oginPortal/AuthenticatedView/AuthenticatedView.tsx 87.50% <ø> (ø)
...inPortal/SecondFactor/DeviceSelectionContainer.tsx 15.78% <ø> (ø)
...LoginPortal/SecondFactor/MethodSelectionDialog.tsx 86.36% <ø> (ø)
...iews/LoginPortal/SecondFactor/SecondFactorForm.tsx 63.04% <ø> (ø)
web/src/views/ResetPassword/ResetPasswordStep1.tsx 69.23% <ø> (ø)
web/src/views/ResetPassword/ResetPasswordStep2.tsx 69.56% <ø> (ø)
... and 3 more

... and 5 files with indirect coverage changes

Copy link

netlify bot commented May 30, 2024

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 43f4934
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/66586837241b730008e78908
😎 Deploy Preview https://deploy-preview-7248--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants