Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep note-offs in demo_wav2midi.py #335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jjburred
Copy link

thanks for the great library!

I noticed many note off events were filtered by demo_wav2midi.py, resulting in a lot of sustained notes in the MIDI output, so I modified the note filtering condition to include all note off triplets starting with 0.

Also, I added some checks to avoid trying to call mido with note or velocity values higher than 127, which results in an error.

@jjburred
Copy link
Author

jjburred commented May 5, 2021

I see a macos compilation check failed on the aubio.aubio pipeline, but can't figure out why since I only modified a Python utility script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant