Make spectral rolloff return bound values #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The current code returns an out of bound bin (length + 1) if everything is contained in the last bin. This returns instead the last bin.
Not really sure where to test that, but here's a small excerpt that shows it working:
It returns
4
(the right value), and if you instead useyou can see it returns 5, one too much.
We could also do it the other way, where you go through the norm array and then break whenever you reach 95% of the energy, but I didn't want to change stuff too much :)