Custom Styles (inc. Settings refactor) #1793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Thanks. Did you intend to make this PR against main, or is there more to come? |
|
Definitely WIP - more to come on this one and then we can see about main 🙂 |
|
This is looking fantastic @kolektiv! 🙌 |
|
This pull request has been mentioned on Atuin Community. There might be relevant details there: |
|
This pull request has been mentioned on Atuin Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Continuing previous pull request...
The Settings refactor is probably a little better than the previous growing flat structure, but it could do with a proper overhaul at some point I think. Still, it should do for now. This should be enough to try and test various configs - in theory it shouldn't have changed the format required, but that's not tested...
Checks