feat(client): Allow sorting filter modes #1717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasJ
force-pushed
the
feat/configurable-filter-modes
branch
from
da8cf55
to
8fb964c
Compare
|
Thank you for the work here! This seems very similar to #1655 :/ Just waiting on @matthiasbeyer in that one (I've been a little slow to review), but I'd rather stick with that PR as it came in much sooner. |
|
Looks like I didn't see that one :/ But yes, I agree that the sooner PR is probably to be preferred. I will keep this one open for now for reference but will close when the other one is accepted :) |
|
Thank you! |
|
Ah, yes sorry that I have not got around to continue my PR. 😞 Feel free to take my patches or close it unmerged, as long as we're getting the feature 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1417
Closes #1654
cc @hco
Checks