Use alpine as base for Docker image #1021
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sierra1011
reviewed
Jan 29, 2024
Sierra1011
reviewed
Jan 29, 2024
| # Install ca-certificates for webhooks to work | ||
| RUN apt update && apt install ca-certificates -y && rm -rf /var/lib/apt/lists/* | ||
| WORKDIR app | ||
| FROM alpine:3.12 as runner |
There was a problem hiding this comment.
Using 3.18 would be a good up-to-date version with plenty of space left in the lifecycle.
|
Hey! Would it be possible to make the UID/GID changes separately please? I'm unlikely to want to change to alpine any time soon. Historically, there have been issues with the musl allocator performing poorly in multi-threaded environments. I wouldn't say not to building an alpine image in addition however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpine based images are 35mb while debian:bullseye-20230502-slim is 135mb.
Docker-compose could use postgres:14-alpine for another reduction in size.
Also added UID/GID to the docker-compose. This is a best practice. Otherwise the container will run with whatever user is running docker, which could be root. The Dockerfile was also modified to run with a user/group of 1000/1000 which also seems to be a common practice. (Ideally, the perms would be fixed as part of the entrypoint/cwd at runtime as well, to match the env vars, but I didn't do that)