Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Allow changing order of filter modes #1654

Open
matthiasbeyer opened this issue Jan 30, 2024 · 2 comments · May be fixed by #1655 or #1717
Open

Feature request: Allow changing order of filter modes #1654

matthiasbeyer opened this issue Jan 30, 2024 · 2 comments · May be fixed by #1655 or #1717

Comments

@matthiasbeyer
Copy link
Contributor

I would like to change the order in which the filter modes are used and actually be able to drop some of them (for example, I do not care about directory filter mode).

This is probably related to #366 - but I am not sure whether we're talking about the very same thing here.
@matthiasbeyer matthiasbeyer linked a pull request Jan 30, 2024 that will close this issue
Open
2 tasks
@arcuru
Copy link
Sponsor Contributor

arcuru commented Jan 30, 2024

If you haven't yet, you should look at #1417. I suggested exactly the feature in your PR, and I believe @ellie agreed that this is probably a good idea.

@matthiasbeyer
Copy link
Contributor Author

matthiasbeyer commented Jan 31, 2024 •
edited

Agreed, this PR you mentioned is somewhat related to this, yes. I'll leave the decision how to move forward up to the maintainers ❤️

dasJ added a commit to dasJ/atuin that referenced this issue Feb 13, 2024
@dasJ
feat(client): Allow sorting filter modes
da8cf55 
Closes atuinsh#1417
Closes atuinsh#1654
@dasJ dasJ linked a pull request Feb 13, 2024 that will close this issue
Open
2 tasks
dasJ added a commit to dasJ/atuin that referenced this issue Feb 14, 2024
@dasJ
feat(client): Allow sorting filter modes
8fb964c 
Closes atuinsh#1417
Closes atuinsh#1654
dasJ added a commit to dasJ/atuin that referenced this issue May 19, 2024
@dasJ
feat(client): Allow sorting filter modes
29fb01c 
Closes atuinsh#1417
Closes atuinsh#1654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arcuru @matthiasbeyer