ESP32: enable jump tables for libAtomVM for Xtensa devices #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
enable-jump-tables-for-libAtomVM
branch
from
be15f06
to
9eb1e79
Compare
Starting from a certain point jump tables are disabled since they are not compatible with moving code to IRAM. Enable that again for libAtomVM since we are not moving code to IRAM for it. See also: espressif/esp-idf@c02aa6d Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
enable-jump-tables-for-libAtomVM
branch
from
9eb1e79
to
246c4aa
Compare
bettio
changed the title
|
There is no evident performance gain, so I will iterate over this PR to make sure the optimization is useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from a certain point jump tables are disabled since they are not compatible with moving code to IRAM.
Enable that again for libAtomVM since we are not moving code to IRAM for it.
See also:
espressif/esp-idf@c02aa6d
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later