This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Update [email protected] #25443
Open
Update [email protected] #25443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RangeError thrown by tree-sitter doesn't say anything about which language is incompatible. By clarifying that this is in fact a tree-sitter error and which language is affected, debugging the source of these errors should be easier.
claytonrcarter
force-pushed
the
update-tree-sitter
branch
from
18571ec
to
68f4ab6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
This updates Atom and relevant bundled languages to tree-sitter v0.20. This helps address (but doesn't really "fix") #22129 and #23041. This PR supercedes #23283.
Description of the Change
There are 3 parts to this update:
language-rust-bundled(which is in the Atom repo)As the pending PRs are reviewed and merged, I will update this PR to remove the submodules and include those as normal version updates.
Updates needed:
Note all languages that are blocked by an existing PR are already included in this PR as git submodules but just for testing and proof of concept. Once all these (or equivalent) PRs are merged, all changes from the commit titled
chore(FIXME): Include PENDING tree-sitter language updates(including the submodules) will be removed form this PR and replaced with normal semver-style dependencies.See also: https://github.com/icecream17/atom-update-backlog/blob/main/Languages.md
Also while I was here, I updated the error message thrown by tree-sitter to make debugging version mismatches a little easier. It doesn't fully address #23041, but I hope that it will help. This is entirely optional though, and I can remove this change if you'd prefer.
Alternate Designs
None considered.
Possible Drawbacks
Once this is updated and released, 3rd party language packages with tree-sitter grammars will stop working until they too are updated.
Verification Process
No new tests were added. I'm just relying on the existing tests and some manual testing.
Release Notes
Atom's tree-sitter support (including core languages with tree-sitter grammars) has been updated.