Implement object type spread (both $Exact and nonexact semantics) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebuilds
suggested changes
Jun 10, 2017
src/convertTypeToPropTypes.js
Outdated
| @@ -194,9 +225,9 @@ converters.GenericTypeAnnotation = (path: Path, opts: Options) => { | |||
| if (typeParametersConverters[name]) { | |||
| return typeParametersConverters[name](path, opts); | |||
| } else { | |||
| throw error( | |||
| debugger;throw error( | |||
src/__tests__/classes.test.js
Outdated
| `, | ||
| }, | ||
|
|
||
| { |
There was a problem hiding this comment.
Can you add tests for context types?
| @@ -50,10 +49,15 @@ function typeToValue(node) { | |||
| return t.valueToNode(value); | |||
| } | |||
|
|
|||
| function isExact(path: Path) { | |||
There was a problem hiding this comment.
Yeah, it should be preferred over $Exact
There was a problem hiding this comment.
|
Changes made on this and #2. |
…ntics and fix flow errors
rosskevin
force-pushed
the
object-type-spread
branch
from
48d149f
to
673d2c2
Compare
|
Trying to get this rebased, but error stack trace line numbers no longer line up...so it's a bit of a pain. |
|
@thejameskyle this is rebased and good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object type spread was introduced in Flow 0.42.0
Documentation is not yet published, but the behavior is documented here and this is referenced in the implementation, as use without
$Exactis odd - it makes all prop values from the spread optional.I have mirrored flow behavior, though I expect the default behavior may change. This too is commented in code so we have some sanity to check and change it in the future.