Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing resolution argument to ghostscript in lattice parser #396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xteo
Copy link

@0xteo 0xteo commented Jan 21, 2020

The lattice parser has a resolution attribute that is never used. A default value of 300 is instead passed to ghostscript.
I changed the ghostscript command to use self.resolution as it was intended.

@codecov-io
Copy link

Codecov Report

Merging #396 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files          13       13           
  Lines        1511     1511           
  Branches      349      349           
=======================================
  Hits         1325     1325           
  Misses        129      129           
  Partials       57       57
Impacted Files Coverage Δ
camelot/parsers/lattice.py 94.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8ac79...b0c0804. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants