Added fileObj to read file object #331
Conversation
|
I'll review this today. |
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 87.2% 84.04% -3.16%
==========================================
Files 13 13
Lines 1501 1561 +60
Branches 348 363 +15
==========================================
+ Hits 1309 1312 +3
- Misses 134 185 +51
- Partials 58 64 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@deepankurtaneja I'm not very keen on having another function called read_fileObj apart from read_pdf in the library's main interface. How does not having the ability to read a file object limit you? That will help me understand your use case better. If it makes sense to add that functionality, we can then think of a better interface.
|
@vinayak-mehta Actually I am trying to read a PDF file while I am uploading it through web application and there I was not able to use read_pdf() method for file object, hence I added the file object function so as to read the PDF while uploading it via web app. |
|
Sorry for the delay in replies, please give me some time to look into this. |
|
Him i'm also interested in this feature, the need to have a local file (or a downloaded local file) prevents me to deploy camelot in a docker container without a volume. Any updates about this PR ? Can i help ? |
|
Hi I would also really appreciate this feature... is there any progress in this task? From what I can see there are already two merge requests on this feature... |
|
just realizing this is a somewhat old? repository? @deepankurtaneja if you read this, get the pull request over here: |
In Camelot there is already present functionality for reading PDF file using file path, but in order to read PDF files through file object was not possible in Camelot directly. Hence added one more function to allow read file object and modified few dependent functions to achieve it. This functionality has been tested on our side, please test it and merge it.