Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stream.py #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

CartierPierre
Copy link

Make the stream grouping row recursively, not only 2 by 2

@vinayak-mehta
Copy link
Contributor

@CartierPierre The change you made is failing a test, can you look into it? And is there an issue associated with this PR?

@CartierPierre
Copy link
Author

I just changed a tab ... It'm not a github expert yet, I don't know how to pass the test

@vinayak-mehta
Copy link
Contributor

It's easy :) most of the tests in here are checking if the actual table extracted from a PDF is the same as the expected table. Your change fails test_stream_columns test because the the output after the change isn't matching the expected output.

The fix for this would be to check if the actual output that you're getting from your change, on your local machine, is in fact better/more correct than the current expected output. And then change the expected output in the file above, if that's the case.

@vinayak-mehta
Copy link
Contributor

I was able to find the failing test by clicking on the Details link on the Travis check.

@vinayak-mehta
Copy link
Contributor

Also, what do you mean by making stream row grouping recursive and not 2 by 2? Is there an issue associated with this?

@CartierPierre
Copy link
Author

Before the fix, if the file is like :

Line1
Line2
Line3

Line4

The output was :

Line1\nLine2
Line3
Line4

But the expected output was :

Line1\nLine2\Line3
Line4

@vinayak-mehta
Copy link
Contributor

Cool, I'll look into and and see if the test needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants