Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bower module #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

darlanmendonca
Copy link

I add a bower.json, with the following

{
  "name": "vocalizer",
  "version": "0.0.9",
  "description": "A simple javascript plugin to show people how to say your name correctly.",
  "main": [
    "dist/vocalizer.min.css",
    "dist/vocalizer.min.js"
  ],
  "authors": [
    "Atif Azam (http://atifaz.am)"
  ],
  "license": "MIT",
  "homepage": ""
}

The more important to works, is the main files

but, I see your markup, and their request a vendor file

To works, this module need give all instructions, to main files, and dependencies

Please, review, and add more things in bower.json if needed, or say to me, I add

at moment, what we really need is add the dependencies, I guess :D

@darlanmendonca darlanmendonca mentioned this pull request Dec 30, 2016
@atifazam
Copy link
Owner

atifazam commented Jan 9, 2017

@darlanmendonca Is this ready to be merged or do I need to add something else? Not very familiar w/ bower.

@darlanmendonca
Copy link
Author

darlanmendonca commented Jan 9, 2017

@atifazam to publish, need three things

  1. bower.json with main file (my commit do that, just check if the version is right pls)

  2. register the module running (once time only, never more :D)

bower register vocalizer https://github.com/atifazam/vocalizer
  1. release a tag, on git, tags publish the version on bower
# create a tag in repo
git tag -a v0.0.9 -m "release version 0.0.9"
# push the tags
git push --tags

@darlanmendonca
Copy link
Author

I see the version, probably you want release the version 1.0.1 right?

confirm the version to me pls, I change and we can merge :D

@atifazam atifazam self-requested a review January 9, 2017 19:20
@atifazam
Copy link
Owner

atifazam commented Jan 9, 2017

1.0.0 is good. We don't need to tag the addition of a bower component as a new version. Thanks!

@darlanmendonca
Copy link
Author

ok, but to publish, you will need recreate the tag (I dont know if this is a good thing), tag 1.0.0 already exists, so need maybe a new tag is better no?

@atifazam
Copy link
Owner

atifazam commented Jan 9, 2017

Okay, a new tag works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants