EHSTPCR-1181: fix for get_datalabs_path #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, it seems all the checks have passed. Please let me know if you need anything else. Thanks a lot! |
|
One question, how are now managing the pre-released versions? are they automatically generated after the PR is closed? thanks for the info! |
Not at the moment, it's all manual. The machinery is broken, but I hope to get funding for infrastructure overhaul and overall maintenance and make the release process more robust and sustainable. |
I did one upload today that includes this PR. |
|
Many thanks @bsipocz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Astroquery team,
This PR aims to fix a small bug associated to the previous pull request, with our new method, get_datalabs_path. In the end, in our Archive FITS are always retrieved as FITS.GZ and, with this fix, we are ensuring this is always considered. Thanks in advance for yout support!
cc @esdc-esac-esa-int