F401 (unused imports) - Help text underlining is confusing

[plredmond]

In #11168 we noticed that the help text is only underlining the as-name part of an unused import, e.g.

47 | from . import renamed as bees # F401: no fix
   |                          ^^^^ F401
   |
   = help: Remove unused import: `.renamed`

This might be confusing for users and should be fixed.

[plredmond]

@zanieb I added this issue at your instruction, but I'm not sure that it's required any longer.

I think the justification for only underlining the /binding/ that is unused, and not the whole /statement/ is because of the case where there are multiple bindings in a single statement, some of which are used and some of which aren't.

Here's a fixture test that demonstrates this:

ruff/crates/ruff_linter/resources/test/fixtures/pyflakes/F401_29__all_conditional/__init__.py

Lines 1 to 16 in 1798425

	"""__init__.py with __all__ populated by conditional plus-eq
	multiple __all__ so cannot offer a fix to add to them
	"""
	import sys
	from . import unused, exported, renamed as bees
	if sys.version_info > (3, 9):
	from . import also_exported
	__all__ = ["exported"]
	if sys.version_info >= (3, 9):
	__all__ += ["also_exported"]

and its resolution:

ruff/crates/ruff_linter/src/rules/pyflakes/snapshots/ruff_linter__rules__pyflakes__tests__preview__F401_F401_29__all_conditional____init__.py.snap

Lines 1 to 24 in 1798425

	---
	source: crates/ruff_linter/src/rules/pyflakes/mod.rs
	---
	__init__.py:8:15: F401 `.unused` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
	|
	6 | import sys
	7 |
	8 | from . import unused, exported, renamed as bees
	| ^^^^^^ F401
	9 |
	10 | if sys.version_info > (3, 9):
	|
	= help: Remove unused import
	__init__.py:8:44: F401 `.renamed` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
	|
	6 | import sys
	7 |
	8 | from . import unused, exported, renamed as bees
	| ^^^^ F401
	9 |
	10 | if sys.version_info > (3, 9):
	|
	= help: Remove unused import