change fix-title for redundant alias case to format itself and return…

… early
astral-sh · May 9, 2024 · 1798425 · 1798425
1 parent ec2d72d
commit 1798425
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/crates/ruff_linter/src/rules/pyflakes/rules/unused_import.rs b/crates/ruff_linter/src/rules/pyflakes/rules/unused_import.rs
@@ -129,7 +129,11 @@ impl Violation for UnusedImport {
  Some(UnusedImportContext::Init {
  first_party: true,
  dunder_all_count: 0,
- }) => "Use an explicit re-export",
+ }) => {
+ return Some(format!(
+ "Use an explicit re-export: `{binding} as {binding}`"
+ ));
+ }
  _ => "Remove unused import",
  };
  Some(if *multiple {

diff --git a/...es/snapshots/ruff_linter__rules__pyflakes__tests__preview__F401_F401_24____init__.py.snap b/...es/snapshots/ruff_linter__rules__pyflakes__tests__preview__F401_F401_24____init__.py.snap
@@ -22,7 +22,7 @@ __init__.py:33:15: F401 [*] `.unused` imported but unused; consider removing, ad
 33 | from . import unused # F401: change to redundant alias
  | ^^^^^^ F401
  |
- = help: Use an explicit re-export: `.unused`
+ = help: Use an explicit re-export: `unused as unused`
 
 ℹ Safe fix
 30 30 | from . import aliased as aliased # Ok: is redundant alias
@@ -39,4 +39,4 @@ __init__.py:36:26: F401 `.renamed` imported but unused; consider removing, addin
 36 | from . import renamed as bees # F401: no fix
  | ^^^^ F401
  |
- = help: Use an explicit re-export: `bees`
+ = help: Use an explicit re-export: `bees as bees`