Add tdx guide for osdk #849
Open
+215
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StanPlatinum Could you give some feedback for this PR? |
Sure! |
tatetian
reviewed
Jun 8, 2024
| -monitor pty \ | ||
| -no-hpet \ | ||
| -nodefaults \ | ||
| -drive file=<Your OS image path in qcow2 format>,if=virtio,format=qcow2 \ |
There was a problem hiding this comment.
This OSDK guide is intended to provide step-by-step instructions so that a reader can follow them to reproduce the result. So we must give concrete values that work out of box. What is the concrete value for <Your OS image path in qcow2 format>?
There was a problem hiding this comment.
Pending on issue #922.
tatetian
reviewed
Jun 9, 2024
Hsy-Intel
force-pushed
the
osdk_tdx_env
branch
2 times, most recently
from
3bf8cc0
to
86909cb
Compare
tatetian
approved these changes
Jun 10, 2024
Hsy-Intel
force-pushed
the
osdk_tdx_env
branch
3 times, most recently
from
71e14f5
to
e714569
Compare
|
Commit updated. I will verify this PR once issue #922 is solved. |
tatetian
reviewed
Jun 11, 2024
Hsy-Intel
force-pushed
the
osdk_tdx_env
branch
2 times, most recently
from
e4790ba
to
94dfc38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.