Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve error tests #407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: improve error tests #407

wants to merge 1 commit into from

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented May 20, 2023

Prerequisites of #392 , to make sure the styles are correct.

Before #156 (comment) gets confirmed, use hard code instead.

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #407 (7b05f3b) into main (2eb7155) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   59.71%   59.71%           
=======================================
  Files          56       56           
  Lines        3664     3664           
=======================================
  Hits         2188     2188           
  Misses       1476     1476           
Impacted Files Coverage Δ
crates/cli/src/error.rs 45.31% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@HerringtonDarkholme HerringtonDarkholme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
However I would like to change the test case a little more.

First, the test case itself is not readable. I have not decided to use which format for colorization test.

Second, the test is for UI. We will probably change it in future so test might be frequently broken.

I would rather test if a colorized string appears in the error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants