Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Abp.EntityFramework.SettingStore #368

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

wocar
Copy link

@wocar wocar commented May 23, 2017

Tests passed 馃憤
Created the nuget locally Abp.EntityFramework.SettingStore-beta2
See aspnetboilerplate/aspnetboilerplate/issues/2152

@hikalkan hikalkan self-requested a review May 23, 2017 18:46
@hikalkan hikalkan added this to the v2.1 milestone May 23, 2017
@hikalkan
Copy link
Member

Thanks a lot for your contribution. I'll review it in a short time.

@wocar
Copy link
Author

wocar commented May 23, 2017

Thank you, first time contributing might've Missed something don't know... I'm glad to do it. Amazing framework 馃槍

@hikalkan
Copy link
Member

Hi,

One question is that: How this new module is supposed to use? I think we should add a DbSet<Setting> property to our DbContext. Right? If so, it would be better to define an interface, like ISettingDbContext that should be implemented by the DbContext.
Second improvement would be renaming SettingModule to AbpEntityFrameworkSettingStoreModule.

@hikalkan hikalkan modified the milestones: v2.2, Backlog Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants