Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Git Script To Persist Old Records #199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saiteja13427
Copy link
Collaborator

@saiteja13427 saiteja13427 commented May 26, 2022

Modified git script to persist the old records and add on top of it. Solves issue #159

Changes

  1. Modified the git script to persist old records.
  2. Added a clear: true key, value pair to the organisation, pull_request and issues JSON files to clear the records when a new user clones and runs the script for the first time.

Reason for changes

As we get only 100 records on every fetch to the API, there is a chance that for people with more than 100 PRs or 100 issues, the previous data will disappear.

To tackle this, we will now be appending any new data to the previous data.

Note: I did not format the JSON files, probably was done by husky pre-commit. Due to that, you will see huge change size. But the only change in those json files is clear: true.

@ashutosh1919
Copy link
Owner

@saiteja13427 merging this one will take time since it is not related to UI.

@saiteja13427
Copy link
Collaborator Author

@ashutosh1919 Sure, I tried covering all the edge cases i could think of, do test it locally with your profile and let me know if you see any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants