Allow user to specify command line args for a1111 webui #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow the user to customize flags by setting the `COMMANDLINE_ARGS` env variable in the docker run. If nothing is passed in, then the defaults are used.
"should" ? Did you test it? |
ashleykleynhans
requested changes
Mar 4, 2024
| @@ -10,7 +10,7 @@ install_dir="/workspace" | |||
| #clone_dir="stable-diffusion-webui" | |||
|
|
|||
| # Commandline arguments for webui.py, for example: export COMMANDLINE_ARGS="--medvram --opt-split-attention" | |||
| export COMMANDLINE_ARGS="--port 3001 --skip-install --listen --api --xformers --enable-insecure-extension-access --no-half-vae" | |||
| test -z "$COMMANDLINE_ARGS" || export COMMANDLINE_ARGS="--port 3001 --skip-install --listen --api --xformers --enable-insecure-extension-access --no-half-vae" | |||
There was a problem hiding this comment.
This does not work correctly, correct syntax is:
: ${COMMANDLINE_ARGS:="--port 3001 --skip-install --listen --api --xformers --enable-insecure-extension-access --no-half-vae"} && export COMMANDLINE_ARGS
There was a problem hiding this comment.
Out of a similar need I've decided to add something along the lines of :
WEBUI_USER_LOCAL=${WEBUI_USER_LOCAL:-webui-user.local.sh}
if [ -x "$WEBUI_USER_LOCAL" ] ; then
source "$WEBUI_USER_LOCAL"
fiI think it gives even more flexibility, as it allows to put the config in /workspace which is helpful for runpod users :D
|
I've addressed this issue in #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow the user to customize flags by setting the
COMMANDLINE_ARGSenv variable in the docker run. If nothing is passed in, then the defaults are used.