Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strict-alias warnings #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix strict-alias warnings #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions base/cfile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

#include <cstdio>

#include "mem_utils.h"

namespace base {

// Reads a WORD (16 bits) using little-endian byte ordering.
Expand Down Expand Up @@ -114,7 +116,7 @@ float fgetf(FILE* file)

// Little endian.
int v = ((b4 << 24) | (b3 << 16) | (b2 << 8) | b1);
return *reinterpret_cast<float*>(&v);
return *copy_reinterpret_cast<float*>(&v);
}

// Reads a 64-bit double-precision floating point number using
Expand Down Expand Up @@ -156,7 +158,7 @@ double fgetd(FILE* file)
((long long)b3 << 16) |
((long long)b2 << 8) |
(long long)b1);
return *reinterpret_cast<double*>(&v);
return *copy_reinterpret_cast<double*>(&v);
}

// Writes a word using little-endian byte ordering.
Expand Down Expand Up @@ -231,7 +233,7 @@ int fputq(long long l, FILE* file)
// Returns 0 in success or -1 in error
int fputf(float l, FILE* file)
{
const int b = *(reinterpret_cast<int*>(&l));
const int b = *(copy_reinterpret_cast<int*>(&l));
int b1, b2, b3, b4;

// Little endian.
Expand All @@ -254,7 +256,7 @@ int fputf(float l, FILE* file)
// Returns 0 in success or -1 in error
int fputd(double l, FILE* file)
{
const long long b = *(reinterpret_cast<long long*>(&l));
const long long b = *(copy_reinterpret_cast<long long*>(&l));
int b1, b2, b3, b4, b5, b6, b7, b8;

// Little endian.
Expand Down
8 changes: 8 additions & 0 deletions base/mem_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,18 @@
#define BASE_MEM_UTILS_H_INCLUDED
#pragma once

#include <cstring>
#include <string>

namespace base {

template<typename T>
T copy_reinterpret_cast(const void* ptr) {
T tmp;
std::memcpy(&tmp, ptr, sizeof(T));
return tmp;
}

std::string get_pretty_memory_size(std::size_t memsize);

} // namespace base
Expand Down
17 changes: 9 additions & 8 deletions base/serialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "config.h"
#endif

#include "base/mem_utils.h"
#include "base/serialization.h"

#include <iostream>
Expand Down Expand Up @@ -57,7 +58,7 @@ std::ostream& little_endian::write64(std::ostream& os, uint64_t qword)

std::ostream& little_endian::write_float(std::ostream& os, float value)
{
const int b = *(reinterpret_cast<int*>(&value));
const int b = *(copy_reinterpret_cast<int*>(&value));
os.put((int)((b & 0x000000ffl)));
os.put((int)((b & 0x0000ff00l) >> 8));
os.put((int)((b & 0x00ff0000l) >> 16));
Expand All @@ -67,7 +68,7 @@ std::ostream& little_endian::write_float(std::ostream& os, float value)

std::ostream& little_endian::write_double(std::ostream& os, double value)
{
const long long b = *(reinterpret_cast<long long*>(&value));
const long long b = *(copy_reinterpret_cast<long long*>(&value));
os.put((int)((b & 0x00000000000000ffl)));
os.put((int)((b & 0x000000000000ff00l) >> 8));
os.put((int)((b & 0x0000000000ff0000l) >> 16));
Expand Down Expand Up @@ -126,7 +127,7 @@ float little_endian::read_float(std::istream& is)
b3 = is.get();
b4 = is.get();
int v = ((b4 << 24) | (b3 << 16) | (b2 << 8) | b1);
return *reinterpret_cast<float*>(&v);
return *copy_reinterpret_cast<float*>(&v);
}

double little_endian::read_double(std::istream& is)
Expand All @@ -148,7 +149,7 @@ double little_endian::read_double(std::istream& is)
((long long)b3 << 16) |
((long long)b2 << 8) |
(long long)b1);
return *reinterpret_cast<double*>(&v);
return *copy_reinterpret_cast<double*>(&v);
}

std::ostream& big_endian::write16(std::ostream& os, uint16_t word)
Expand Down Expand Up @@ -182,7 +183,7 @@ std::ostream& big_endian::write64(std::ostream& os, uint64_t qword)

std::ostream& big_endian::write_float(std::ostream& os, float value)
{
const int b = *(reinterpret_cast<int*>(&value));
const int b = *(copy_reinterpret_cast<int*>(&value));
os.put((int)((b & 0xff000000l) >> 24));
os.put((int)((b & 0x00ff0000l) >> 16));
os.put((int)((b & 0x0000ff00l) >> 8));
Expand All @@ -192,7 +193,7 @@ std::ostream& big_endian::write_float(std::ostream& os, float value)

std::ostream& big_endian::write_double(std::ostream& os, double value)
{
const long long b = *(reinterpret_cast<long long*>(&value));
const long long b = *(copy_reinterpret_cast<long long*>(&value));
os.put((int)((b & 0xff00000000000000l) >> 56));
os.put((int)((b & 0x00ff000000000000l) >> 48));
os.put((int)((b & 0x0000ff0000000000l) >> 40));
Expand Down Expand Up @@ -251,7 +252,7 @@ float big_endian::read_float(std::istream& is)
b2 = is.get();
b1 = is.get();
int v = ((b4 << 24) | (b3 << 16) | (b2 << 8) | b1);
return *reinterpret_cast<float*>(&v);
return *copy_reinterpret_cast<float*>(&v);
}

double big_endian::read_double(std::istream& is)
Expand All @@ -273,7 +274,7 @@ double big_endian::read_double(std::istream& is)
((long long)b3 << 16) |
((long long)b2 << 8) |
(long long)b1);
return *reinterpret_cast<double*>(&v);
return *copy_reinterpret_cast<double*>(&v);
}


Expand Down