Multiple spectrum indicators 4338

[Charlie-83]

#4338

I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md

I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing

This is super rough right now but opening PR to gauge interest in this feature.

TODO:

• Multiple indicators for bottom bars
  • Saturation bar
  • Alpha bar
• Saturation bar indicators should all be black or all be white
• Have some way of showing which indicator in the main area corresponds to which indicator in the bottom bar. I'm thinking either having each indicator be a different shape/colour or drawing a dotted line between the connected indicators.
• Multiple indicators for other colour selectors
• Probably want to store the shade as m_shade on the colour selector
• Render the spectrum using the maximum saturation among selected colours

[dacap]

Thanks for this PR @Charlie-83, I've been testing this, and it looks a little confusing seeing all the indicators at the same time (with the same color).

Not sure if it's useful (probably it could be a switchable option, off by default), Probably seeing the indicators with a some alpha blending (50%) might be useful to differentiate between the current indicator and the other colors indicators, or avoid showing indicators for all colors and just show a dotted line connecting all points (and show the indicator only in the current color).

[Charlie-83]

Thanks for having a look @dacap I really like the idea of showing one indicator and then a dotted line for the rest since the main point of the feature is to be able to visualize color curves (although that's gonna be harder to do since the logic for drawing the indicators was already there).

This is currently just a rough hack. I'll find some time to work on it some more.

[aseprite-bot]

clang-tidy made some suggestions

[aseprite-bot]

clang-tidy made some suggestions

[aseprite-bot]

clang-tidy made some suggestions

[Charlie-83]

Here is what I have it looking like now

[dacap]

I was doing some testing and I think we are getting closer. I'm not 100% convinced to enable this by default, but can be useful for some users.

Some issues I've found:

1. Probably it would make sense to draw a line between the near hue distance:

2. Sometimes the line is not visible

I didn't review the code yet.

[Charlie-83]

I'll fix those issues. I agree that this is probably best as an option in the settings default off so I'll work on adding a setting for this too