Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable websocket SSL/TLS support #4339

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

samedii
Copy link

@samedii samedii commented Feb 24, 2024

Just creating this to show that it should be relatively easy to support. Will close it. I expect there may be more considerations of course.

Compiled with this setup: https://github.com/nilsve/docker-aseprite-linux

@dacap
Copy link
Member

dacap commented Feb 25, 2024

Adding this flag makes IXWebSocket depends on OpenSSL or mbedtls (macOS is the only one that use its native securetranport framework), and at the moment we're not distributing these libraries. Anyway we want to make curl work on Linux (so we can enable Sentry on Linux too) and add possible HTTPS requests from Lua scripts. So adding mbedtls is an option here. Something to investigate a little more (as the Linux port needs the distribution of certificates/etc.).

@dacap dacap added the tls Features that depends on a TLS layer label Feb 25, 2024
@samedii
Copy link
Author

samedii commented Feb 25, 2024

Yes but maybe it's nicer for end users if you link it statically instead of depending on shared. I don't think linux needs certificates, I think that's only for the server side implementation.

Nice to hear that you're open to something like this 👍

I did a quick test doing static linking for everything but got stuck on libGL if I remember correctly.

Note that only allowing insecure websockets is problematic sometimes because some providers seem to force upgrade to https.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tls Features that depends on a TLS layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants