Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALL.md for windows compilation such that a misleading arch… #4239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dev-nt90
Copy link

…itecture option is avoided when calling the developer command prompt

As it exists today, the provided call "...VsDevCmd.bat" -arch=x64 command will output the developer command prompt at startup then close itself after a few seconds. What's going on, is the command prompt is silently failing, because it doesn't recognize the "x64" value for the -arch argument.

This change makes the example call have a generic value for target architecutre, and links to the documentation where the valid values can be reviewed.

I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md

I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing

…itecture option is avoided when calling the developer command prompt

As it exists today, the provided `call "...VsDevCmd.bat" -arch=x64` command will output the developer command prompt at startup then close itself after a few seconds. What's going on, is the command prompt is silently failing, because it doesn't recognize the "x64" value for the -arch argument. 

This change makes the example `call` have a generic value for target architecutre, and links to the documentation where the valid values can be reviewed.
@dev-nt90 dev-nt90 requested a review from dacap as a code owner December 22, 2023 14:43
@dacap
Copy link
Member

dacap commented Dec 22, 2023

Hi @dev-nt90, I think most user will just copy and paste the command line example without even touching the <target architecture>. I'm not sure if we should incorporate this change to the guide.

What I cannot believe is why Microsoft removed the x64 CLI access to MSVC from the start menu and it defaulted to x86 (the least used arch).

@dev-nt90
Copy link
Author

@dacap That's fair. If we're concerned with the most common path, then what I think makes most sense is setting the arch value to "amd64", as that's what most people will be using, while leaving a reference to the target arch documentation for the more exotic cases.

@dev-nt90
Copy link
Author

@dacap the aforementioned changes are committed at e2438e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants