Block quotes for the semantic HTML 5 Converter #4549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds functionality to convert block-quotes in AsciiDoctor for the semantic-html5 converter/backend. I've added the examples from the asciidoctor manual as tests. The
blockquotes-6
test requires unordered lists, which is blocked by MR #4321.This is an example of the old and new output.
OLD:
NEW:
The use of
<header>
for the title matches my latest [suggestions for admonitions]. The use of<footer>
matches MDNs examples https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote.