feature: add an option to send bytes with ws #1828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoniGang
changed the title
YoniGang
changed the title
|
I uploaded it without automatic tests. Just tested it myself. We use it in my work to test out web sockets. I would be glad to get some help with tests. |
|
|
hassy
reviewed
Feb 23, 2023
|
|
||
| const get_bytes_payload = (payload) => { | ||
| if (typeof payload === 'string') { | ||
| let utf8Encode = new TextEncoder() |
There was a problem hiding this comment.
Is there a particular reason to use TextEncoder here? is that a common way to encode binary data for WebSockets?
There was a problem hiding this comment.
Actually not. It was just a way that I found to turn string into bytes with js. I wanted that there will be an option to send string as bytes as well.
|
thank you @YoniGang! adding a test should be fairly straightforward, I'll try to put a quick one together today that we can iterate on if needed. |
|
Hii @hassy! Oo you have any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to send bytes through web sockets.
Including an example of a function that sends stream and example of how to send bytes with a string without a function
Issue ref: #1780