Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

Added support for non-square icon sizes #130

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rtercias
Copy link

Adds support for non-square icon sizes (WxH) and fills in background with the image's top/left pixel.
Ex.

{
  ios: 'startup',
  src: path.resolve('./tests/icon.png'),
  destination: 'icons',
  sizes: ['640x1136', '828x1792']
}

Also fixes broken tests:

  1. runTests was failing because it attempts to "read" the folder icons. Added a directory check to skip.
  2. tests were failing due to incorrect webpack hash in my local machine, so I updated some of the expected output files (seems like a known webpack issue) [https://github.com/Webpack 4 chunkhash/contenthash can vary between builds webpack/webpack#7179]
  3. fixed test-87, which was failing silently because there was no support for typeof size === 'string' on icons/index.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant