Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/writer formatter #162

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

Feat/writer formatter #162

wants to merge 18 commits into from

Conversation

samy-dougui
Copy link

@samy-dougui samy-dougui commented Aug 13, 2021

Make sure you have checked all steps below.

Issue

  • Add a Zstd formatter for the writter to allow zstd file to be written

Description

  • Add a formatter class for Njson and Zstd
  • Refacto some of the writter code
  • Fix some bugs for gcs writter and gcs reader

Tests

  • No testing yet

Commits

  • I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@samy-dougui samy-dougui marked this pull request as ready for review August 23, 2021 09:39
@samy-dougui
Copy link
Author

I don't have access to a s3 storage or an Azure Blob storage so i can't test it thoroughly.
Let me know what you think about this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant