Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim UI input #12

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Vim UI input #12

wants to merge 9 commits into from

Conversation

ThyW
Copy link
Contributor

@ThyW ThyW commented Sep 6, 2022

finished cooking up a fix for #9: migrating NuiInput to vim.ui.input.

it would maybe be a nice addition to also change the docs, i will maybe take a look at it, but i'm not promising anything.

fixed a stylua lint on the old pr and i also renamed the branch, that's why it closed. sorry about that 馃槄

@ThyW ThyW mentioned this pull request Sep 6, 2022
Copy link
Owner

@arnarg arnarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
Since we're moving away from Nui's input (a class api) to vim.ui.input (just a function with a callback) there's no need for the Prompt class to exist.
I would instead just rename init to open_prompt or something similar and remove the setmetatable stuff which makes it a class in Lua.

I'm writing this on my phone so I hope my explanation is clear.

lua/todotxt-nvim/ui/prompt.lua Outdated Show resolved Hide resolved
@arnarg
Copy link
Owner

arnarg commented Sep 11, 2022

This looks good but I'm hesitant to merge this to main until I have time to update the documentation.
Hopefully I'll have some time soon.

@ThyW
Copy link
Contributor Author

ThyW commented Sep 11, 2022

For sure, no worries. I'm starting university tomorrow so I'm not sure how much time exactly I'm going to have, but I'll still try to keep contributing, mainly fixing #10.

Anyways, I really appreciate all the feedback and I'll try to get more work done asap!

Thanks again.

@matawed
Copy link

matawed commented Sep 8, 2023

Thanks @ThyW for creating https://github.com/ThyW/todotxt.nvim/tree/vim-ui-input

I'll also use it now. However, it's been around for quite a while. How to continue here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants