Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #6528 opi-zero2w, ethernet PHY not powered #6617

Merged
merged 16 commits into from
Jun 2, 2024

Conversation

chraac
Copy link
Collaborator

@chraac chraac commented May 17, 2024

Description

Add some patches to fix the ethernet PHY on orangepi zero2w, includes:

Jira reference number [AR-9999]

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test with ifconfig -a, shows that the eth0 is up
    image

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@chraac chraac marked this pull request as draft May 17, 2024 12:36
@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related - kernel, u-boot, patches labels May 17, 2024
@chraac chraac added the Work in progress Unfinished / work in progress label May 17, 2024
@pyavitz
Copy link
Collaborator

pyavitz commented May 17, 2024

OrangePi's aren't the only units that use emac1. I suggest you isolate the patch work so that it is easier to work with. OrangePi DTS specific changes should have its own patch, as should the driver(s) and H616 DTSI.

@chraac
Copy link
Collaborator Author

chraac commented May 17, 2024

OrangePi's aren't the only units that use emac1. I suggest you isolate the patch work so that it is easier to work with. OrangePi DTS specific changes should have its own patch, as should the driver(s) and H616 DTSI.

yeah, that will be good to apply this patch just for zero2w, will take a look at other pr to figure out how to do that. thanks for your tip.

@chraac chraac self-assigned this May 17, 2024
@alexl83
Copy link
Contributor

alexl83 commented May 17, 2024

thanks @chraac for your big efforts!

@igorpecovnik igorpecovnik added the 08 Milestone: Third quarter release label May 21, 2024
@chraac
Copy link
Collaborator Author

chraac commented May 24, 2024

@pyavitz push an update about split the DTS changes from driver patch, now have a separated patch for the DTS :)

@chraac
Copy link
Collaborator Author

chraac commented May 25, 2024

@pyavitz push an update about split the DTS changes from driver patch, now have a separated patch for the DTS :)

Next will spilt the dts change from pwm driver patch, so that we can reuse the pwm patch in other sbc.

@chraac chraac marked this pull request as ready for review May 29, 2024 12:58
@chraac chraac changed the title [WIP] Fix issue #6528 opi-zero2w, ethernet PHY not powered Fix issue #6528 opi-zero2w, ethernet PHY not powered May 30, 2024
@chraac chraac removed the Work in progress Unfinished / work in progress label May 30, 2024
@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Jun 2, 2024
@igorpecovnik igorpecovnik merged commit cc30042 into armbian:main Jun 2, 2024
11 checks passed
@chraac chraac deleted the dev-zero2w-fix-eth branch June 2, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Hardware Hardware related - kernel, u-boot, patches Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

None yet

4 participants