Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcm2711: restore lost RPI_DEBUG_CONSOLE #6425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rpardini
Copy link
Member

bcm2711: restore lost RPI_DEBUG_CONSOLE

  • bcm2711: restore lost RPI_DEBUG_CONSOLE
    • if RPI_DEBUG_CONSOLE=yes:
      • config.txt:
        • enable_uart=1
        • dtoverlay=disable-bt
      • cmdline.txt:
        • console=tty1 console=ttyAMA0,115200 loglevel=7
    • this was lost in revision 1c3b7ec for some reason

@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related - kernel, u-boot, patches labels Mar 23, 2024
@rpardini rpardini requested a review from viraniac March 23, 2024 16:04
@rpardini rpardini marked this pull request as ready for review March 23, 2024 16:04
@rpardini rpardini force-pushed the pr/bcm2711-restore-lost-RPIDEBUGCONSOLE branch from 8d15303 to 9630931 Compare March 25, 2024 17:51
@viraniac
Copy link
Collaborator

It wasn't really lost. I removed it on purpose as whether the bluetooth needs to be disabled or not depends on the raspberry pi board being used by the user. As boot partition can usually easily be mounted across platforms, I just figured whoever needs it can simply modify the config.txt file either maually or can use some the hook system to modify the same.

However I don't have any issues if you want to bring it back either.

@rpardini
Copy link
Member Author

Thanks for explanation Gunjan. This is an anomaly (as most rpi/broadcom stuff) that requires all those different changes (cmdline, config.txt) instead of a single simple setting like every other board. If they're different across boards, I could make this rpi4b specific somehow. Do you know what difference the other boards would have? I've seen miniuart-something around.

I wouldn't insist on this except for the fact I'm producing images for usage in automated rigs (PXE-booting, testing labs, etc) where I need UART to work out-of-the box from the first boot, thus your remove it cos it's easy to enable after you already got in to the machine somehow else doesn't really resonate.

@rpardini rpardini force-pushed the pr/bcm2711-restore-lost-RPIDEBUGCONSOLE branch 2 times, most recently from 131bb7f to 7377b29 Compare March 30, 2024 11:42
@viraniac
Copy link
Collaborator

viraniac commented Apr 3, 2024

I could make this rpi4b specific somehow

May be you can use conditional filtering in config.txt by adding a [pi4] section

I wouldn't insist on this except for the fact I'm producing images for usage in automated rigs (PXE-booting, testing labs, etc) where I need UART to work out-of-the box from the first boot, thus your remove it cos it's easy to enable after you already got in to the machine somehow else doesn't really resonate.

As I said before, feel free to bring it back. Armbian also supports extensions and userpatches and customization scripts so there were plenty of ways to bring it into image as well if needed. Not just by manually updating the system. But you ofcourse already know that :)

@rpardini rpardini force-pushed the pr/bcm2711-restore-lost-RPIDEBUGCONSOLE branch from 7377b29 to bf1af33 Compare April 27, 2024 09:53
@rpardini rpardini force-pushed the pr/bcm2711-restore-lost-RPIDEBUGCONSOLE branch from bf1af33 to 294b2ba Compare May 28, 2024 17:28
- if `RPI_DEBUG_CONSOLE=yes`:
  - `config.txt`:
    - `enable_uart=1`
    - `dtoverlay=disable-bt`
  - `cmdline.txt`:
    - `console=tty1 console=ttyAMA0,115200 loglevel=7`
- this was lost in revision 1c3b7ec for some reason
@rpardini rpardini force-pushed the pr/bcm2711-restore-lost-RPIDEBUGCONSOLE branch from 294b2ba to 4002ee2 Compare June 3, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related - kernel, u-boot, patches size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

None yet

2 participants