-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Support logging transceiver in monitor layer1 #3991
Merged
ClausHolbechArista
merged 12 commits into
aristanetworks:devel
from
laxmikantchintakindi:layer1
May 21, 2024
Merged
Feat(eos_cli_config_gen): Support logging transceiver in monitor layer1 #3991
ClausHolbechArista
merged 12 commits into
aristanetworks:devel
from
laxmikantchintakindi:layer1
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-3991
# Activate the virtual environment
source test-avd-pr-3991/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@layer1#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,layer1 --force
# Optional: Install AVD examples
cd test-avd-pr-3991
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
May 14, 2024
MaheshGSLAB
reviewed
May 14, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-layer1.j2
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
May 14, 2024
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_layer1.schema.yml
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
May 14, 2024
Vibhu-gslab
reviewed
May 15, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-layer1.j2
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/monitor-layer1.j2
Outdated
Show resolved
Hide resolved
Vibhu-gslab
requested changes
May 16, 2024
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_layer1.schema.yml
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/monitor-layer1-enabled.yml
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/monitor-layer1.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/hosts.ini
Outdated
Show resolved
Hide resolved
Vibhu-gslab
changed the title
Feat(eos_cli_config_gen): Support logging transcevier in monitor layer1.
Feat(eos_cli_config_gen): Support logging transceiver in monitor layer1.
May 16, 2024
laxmikantchintakindi
force-pushed
the
layer1
branch
from
May 17, 2024 10:01
654fdae
to
d6c1ed0
Compare
Vibhu-gslab
reviewed
May 17, 2024
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/monitor-layer1.j2
Outdated
Show resolved
Hide resolved
Shivani-gslab
requested changes
May 20, 2024
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_layer1.schema.yml
Outdated
Show resolved
Hide resolved
Vibhu-gslab
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Shivani-gslab
approved these changes
May 20, 2024
…s/schema_fragments/monitor_layer1.schema.yml Co-authored-by: Vibhu-gslab <[email protected]>
for more information, see https://pre-commit.ci
ClausHolbechArista
requested changes
May 21, 2024
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/monitor-layer1.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
May 21, 2024
ClausHolbechArista
changed the title
Feat(eos_cli_config_gen): Support logging transceiver in monitor layer1.
Feat(eos_cli_config_gen): Support logging transceiver in monitor layer1
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The data model for monitor_layer1 currently required that logging_transceiver have either dom or communication defined to create separate commands. These commands are not supported on some hardware + software, where the command allowed would be 'logging transceiver'. The impact is that the eos_cli has to be used in the meantime to define the correct command.
Related Issue(s)
Fixes #3758
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Add a key under monitor_layer1 to support required command.
How to test
Checklist
User Checklist
Repository Checklist