Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Support logging transceiver in monitor layer1 #3991

Merged
merged 12 commits into from
May 21, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented May 14, 2024

Change Summary

The data model for monitor_layer1 currently required that logging_transceiver have either dom or communication defined to create separate commands. These commands are not supported on some hardware + software, where the command allowed would be 'logging transceiver'. The impact is that the eos_cli has to be used in the meantime to define the correct command.

Related Issue(s)

Fixes #3758

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add a key under monitor_layer1 to support required command.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-3991
# Activate the virtual environment
source test-avd-pr-3991/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@layer1#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,layer1 --force
# Optional: Install AVD examples
cd test-avd-pr-3991
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated role: eos_designs issue related to eos_designs role labels May 14, 2024
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label May 14, 2024
@Vibhu-gslab Vibhu-gslab changed the title Feat(eos_cli_config_gen): Support logging transcevier in monitor layer1. Feat(eos_cli_config_gen): Support logging transceiver in monitor layer1. May 16, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review May 17, 2024 10:10
@laxmikantchintakindi laxmikantchintakindi requested review from a team as code owners May 17, 2024 10:10
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft May 21, 2024 05:52
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review May 21, 2024 06:35
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Support logging transceiver in monitor layer1. Feat(eos_cli_config_gen): Support logging transceiver in monitor layer1 May 21, 2024
@ClausHolbechArista ClausHolbechArista merged commit bea6b27 into aristanetworks:devel May 21, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Support logging transceiver in monitor layer1
5 participants