Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(cv_deploy): Detect pathfinder metadata studio version and skip unsupported fields #3986

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Detect pathfinder metadata studio version and skip unsupported fields

Component(s) name

arista.avd.cv_deploy

How to test

  • Tested manually with wrong versions and older versions.
  • More manual testing will be done when merged.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners May 13, 2024 12:18
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-3986
# Activate the virtual environment
source test-avd-pr-3986/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/cv_deploy/detect-metadata-studio-version#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/cv_deploy/detect-metadata-studio-version --force
# Optional: Install AVD examples
cd test-avd-pr-3986
ansible-playbook arista.avd.install_examples

…workflows/deploy_cv_pathfinder_metadata_to_cv.py
@github-actions github-actions bot added the state: conflict PR with conflict label May 23, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label May 23, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann added this to the v4.8.0 milestone May 24, 2024
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gmuloc gmuloc merged commit 3ea9fc6 into aristanetworks:devel May 24, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants