-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add support for local internet exit #3952
Feat(eos_designs): Add support for local internet exit #3952
Conversation
b83f1cd
to
6ef325f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things. Other than that LGTM.
...llections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge.cfg
Outdated
Show resolved
Hide resolved
...llections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Outdated
Show resolved
Hide resolved
...d/roles/eos_designs/schemas/schema_fragments/cv_pathfinder_internet_exit_policies.schema.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments!
Thanks for the great code
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Outdated
Show resolved
Hide resolved
...ons/arista/avd/roles/eos_designs/python_modules/network_services/router_service_insertion.py
Outdated
Show resolved
Hide resolved
...ons/arista/avd/roles/eos_designs/python_modules/network_services/router_service_insertion.py
Outdated
Show resolved
Hide resolved
b4f1690
to
6a72894
Compare
...ollections/arista/avd/roles/eos_designs/python_modules/network_services/tunnel_interfaces.py
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
e5b3fef
to
7fb62cd
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
...ollections/arista/avd/roles/eos_designs/docs/tables/node-type-l3-interfaces-configuration.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Show resolved
Hide resolved
9b89354
to
e1915e7
Compare
...ions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-transit1A.cfg
Show resolved
Hide resolved
...ions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-transit1A.cfg
Show resolved
Hide resolved
...ions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-transit1A.cfg
Show resolved
Hide resolved
...ions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-transit1A.cfg
Show resolved
Hide resolved
…a_fragments/cv_pathfinder_internet_exit_policies.schema.yml
58df4a8
to
70bf95e
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Change Summary
Add support for local internet exit for Caravan Deployments.
Related Issue(s)
Component(s) name
arista.avd.eos_designs
Proposed changes
Add type
direct
in cv_pathfinder_internet_exit policy type.How to test
molecule
Checklist
User Checklist
Repository Checklist