Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add support for local internet exit #3952

Merged

Conversation

ayushmittal-arista
Copy link
Contributor

Change Summary

Add support for local internet exit for Caravan Deployments.

Related Issue(s)

Component(s) name

arista.avd.eos_designs

Proposed changes

Add type direct in cv_pathfinder_internet_exit policy type.

How to test

molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ayushmittal-arista ayushmittal-arista requested review from a team as code owners May 6, 2024 14:13
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels May 6, 2024
@ayushmittal-arista ayushmittal-arista force-pushed the zscalerLocal branch 2 times, most recently from b83f1cd to 6ef325f Compare May 7, 2024 07:58
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. Other than that LGTM.

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments!

Thanks for the great code

@github-actions github-actions bot added the state: conflict PR with conflict label May 10, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ayushmittal-arista ayushmittal-arista force-pushed the zscalerLocal branch 2 times, most recently from 9b89354 to e1915e7 Compare May 14, 2024 07:06
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label May 14, 2024
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label May 22, 2024
@carlbuchmann carlbuchmann added this to the v4.8.0 milestone May 23, 2024
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit 67cf6bd into aristanetworks:devel May 24, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants