Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump(requirements): Set minimum ansible-core version to 2.15.x and maximum to 2.17.x #3927

Merged
merged 10 commits into from
May 24, 2024
Merged

Bump(requirements): Set minimum ansible-core version to 2.15.x and maximum to 2.17.x #3927

merged 10 commits into from
May 24, 2024

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Apr 30, 2024 •
edited

Change Summary

Set the minimum ansible-core version to 2.15.x and the maximum version to 2.17.x

Required for Ansible collection certification:

The life cycle for Ansible Automation Platform (AAP) 2.3 is ending soon. On May 31, 2024, AAP 2.3 and by extension, Ansible Core 2.14, will be End of Life (EoL).

After this date, all collections submitted for certification and validation must require Ansible Core 2.15 at minimum in the collection’s “meta/runtime.yml” file. Set the requires_ansible key to “>=2.15.0” to pass certification after the AAP 2.3 EoL date.

Component(s) name

Ansible Collection requirements

Proposed changes

Updated:

  • documentation collection-installation.md
  • release notes (4.8.0 placeholder)
  • requirements-dev.txt
  • pre-commit-config.yml
  • GitHub workflows (pull-request-management)
  • meta/runtime.yml
  • update unit test values in test_verify_requirements.py
  • new requirements-dhcp.txt to cap the python requests library due to an issue with docker in molecule workflow

How to test

CI Must pass!

To do before merging!

  • Update release notes with correct release number
  • Update eos_designs Molecule scenario currently testing with 'ansible-core==2.17.0rc1' and --extra-vars 'avd_ignore_requirements=True'
  • Clean up testing with 2.17.0rc1

@carlbuchmann carlbuchmann requested review from a team as code owners April 30, 2024 19:18
@github-actions github-actions bot added type: documentation Improvements or additions to documentation type: code quality CI and development toolset labels Apr 30, 2024
@ClausHolbechArista ClausHolbechArista changed the title Bump: Set minimum ansible-core version to 2.15 Bump(requirements): Set minimum ansible-core version to 2.15 May 1, 2024
ClausHolbechArista
ClausHolbechArista reviewed May 1, 2024
View reviewed changes
ansible_collections/arista/avd/docs/release-notes/4.x.x.md Outdated
@@ -14,6 +14,13 @@ title: Release Notes for AVD 4.x.x

<!-- Release notes generated using configuration in .github/release.yml at devel -->

## Release 4.8.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on timing of 4.8.0, ansible-core 2.17 may be out. I think it would be good to wait for that, so we bump min and max at the same time. ETA for 2.17 is May 20.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - converting to draft and we will re-visit after May 20 once 2.17 is released.
I will work on the PR to make it ready for 2.17.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlbuchmann 2.17 is out. Let's finish this one.

@carlbuchmann carlbuchmann marked this pull request as draft May 1, 2024 13:38
@carlbuchmann carlbuchmann force-pushed the bump-ansible-core branch 2 times, most recently from a180bd5 to 7e43f87 Compare May 1, 2024 15:13
@ClausHolbechArista ClausHolbechArista added this to the v4.8.0 milestone May 3, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label May 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label May 16, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista mentioned this pull request May 21, 2024
Closed
@carlbuchmann carlbuchmann changed the title Bump(requirements): Set minimum ansible-core version to 2.15 Bump(requirements): Set minimum ansible-core version to 2.15.x and maximum to 2.17.x May 21, 2024
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label May 22, 2024
@carlbuchmann carlbuchmann marked this pull request as ready for review May 22, 2024 19:30
@carlbuchmann carlbuchmann requested review from ClausHolbechArista and a team May 22, 2024 19:30
ClausHolbechArista
ClausHolbechArista approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single suggestion but otherwise fine for me.

.github/workflows/pull-request-management.yml
@@ -203,19 +204,20 @@ jobs:
- 'example-l2ls-fabric'
- 'example-single-dc-l3ls'
ansible_version:
- 'ansible-core<2.17.0 --upgrade'
# Testing all scenario with 2.16.x, due to bug with in 2.17.0 with and the way we test eos_designs_negative_unit_tests https://github.com/ansible/ansible/issues/83292
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of running everything else on the older version we could remove the negative unit test form the top matrix and insert it under the include. Up to you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I certainly can, my thinking was having more extensive testing on the 2.16 train since it's going into critical bug fix only and likely what customers target vs the new 2.17.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need less testing when there are only bugfixes going in to the ansible code. And we would still be testing 2.16 for unit tests below.

@github-actions github-actions bot added the state: conflict PR with conflict label May 23, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Vibhu-gslab
Vibhu-gslab approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot removed the state: conflict PR with conflict label May 23, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@sugetha24 sugetha24 self-requested a review May 23, 2024 18:17
sugetha24
sugetha24 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@sugetha24 sugetha24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
molecule test - PASSED

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@carlbuchmann carlbuchmann merged commit b03f1b7 into aristanetworks:devel May 24, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@sugetha24 sugetha24 sugetha24 approved these changes

@Vibhu-gslab Vibhu-gslab Vibhu-gslab approved these changes

Assignees

@carlbuchmann carlbuchmann

Labels
rn: Bump(requirements) state: CI Updated CI scenario have been updated in the PR type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlbuchmann @sugetha24 @ClausHolbechArista @Vibhu-gslab