Feat(eos_cli_config_gen): Redo the model for additional-paths in BGP #3730
+148
−897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
laxmikantchintakindi
force-pushed
the
bgpadditional
branch
from
49ab207
to
1fc1c01
Compare
|
This will break existing deployments since you are changing an existing model in a non-backwards-compatible way. |
| neighbor {{ neighbor.ip_address }} additional-paths send ecmp limit {{ neighbor.additional_paths.send.ecmp_limit }} | ||
| {% elif neighbor.additional_paths.send.limit is arista.avd.defined %} | ||
| neighbor {{ neighbor.ip_address }} additional-paths send limit {{ neighbor.additional_paths.send.limit }} | ||
| {% if neighbor.additional_paths.ecmp_limit is arista.avd.defined %} |
There was a problem hiding this comment.
this should also check if send has the correct value. Same for limit.
There was a problem hiding this comment.
i added valid_values key under 'send' in schema. Also added min, max value for limit.
Comment on lines
20
to
29
| ecmp_limit: | ||
| type: int | ||
| description: Amount of ECMP paths to send. If this key-value pair is not set, it will send all paths in best ECMP group. | ||
| convert_types: | ||
| - str | ||
| min: 2 | ||
| max: 64 | ||
| limit: | ||
| type: int | ||
| description: Number of paths to send through bgp updates(The value of 'send' key must be 'limit'). |
There was a problem hiding this comment.
We may have to rename the ecmp_limit -> send_ecmp_limit and limit -> send_limit. Just in case there will alter come some receive limit options.
|
This changes are kept hold till AVD5.0 release. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
added
data model change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Redo the model for additional-paths in BGP to reduce number of key-value pairs and avoid repeated use of block of code using defs.
Related Issue(s)
Fixes #3279
Component(s) name
`arista.avd.eos_cli_config_gen
Proposed changes
Enhancing code by replacing multiple key-value pairs with boolean values with the help of valid_values key.
Using defs to avoid repeated use of a block of code.
How to test
Checklist
User Checklist
Repository Checklist