fix(anta): Fix anta exec clear-counters by adding supported platforms #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtache
reviewed
Mar 25, 2024
anta/device.py
Outdated
| @@ -171,12 +171,13 @@ async def collect_commands(self, commands: list[AntaCommand]) -> None: | |||
| """ | |||
| await asyncio.gather(*(self.collect(command=command) for command in commands)) | |||
|
|
|||
| def supports(self, command: AntaCommand) -> bool: | |||
| def supports(self, command: AntaCommand, *, log: bool = True) -> bool: | |||
There was a problem hiding this comment.
Any reason why using a boolean for logging and set it to True only once ?
I would suggest to remove this boolean and put the warning where it was :)
carl-baillargeon
force-pushed
the
fix/issue-513
branch
from
25004f4
to
dd2fb14
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add platform_utils.py to be able to properly run or skip tests.
Fixes #513 #607
Checklist: