Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake Build scripts and MSVC support #2045

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

CMake Build scripts and MSVC support #2045

wants to merge 22 commits into from

Commits on Mar 24, 2023

  1. add initial partialy working cmake configuration 

    Signed-off-by: Rachel Powers <[email protected]>
    @Ryex
    Ryex committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    8f57b06 View commit details
    Browse the repository at this point in the history

  2. fix typo that droped 3/4 of the srouce 

    generate config.h

Signed-off-by: Rachel Powers <[email protected]>
    @Ryex
    Ryex committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    fb7c8d2 View commit details
    Browse the repository at this point in the history

  3. fix droped Message digest configureation 

    aria2c now compiles under cmake (atleast under linux)

Signed-off-by: Rachel Powers <[email protected]>
    @Ryex
    Ryex committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    2e890e4 View commit details
    Browse the repository at this point in the history

  4. finish up wslay configuration 

    Signed-off-by: Rachel Powers <[email protected]>
    @Ryex
    Ryex committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    99def35 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. add defines and macros to support MSVC

    @Ryex
    Ryex committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    731aec3 View commit details
    Browse the repository at this point in the history

  2. fix windows io headers

    @Ryex
    Ryex committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    549d8ff View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2023

  1. fix inverted windows detection logic and typo

    @Ryex
    Ryex committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    c7e5767 View commit details
    Browse the repository at this point in the history

  2. more windows headers 

    pullin the CRT equivalents for some things
ensure gai_strerror and getaddrinfo play nice
    @Ryex
    Ryex committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    b66d981 View commit details
    Browse the repository at this point in the history

  3. Use MSVC CRT equivalents without conflicting with posix names

    @Ryex
    Ryex committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    d0b2823 View commit details
    Browse the repository at this point in the history

  4. getopt under MSVC

    @Ryex
    Ryex committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    38426a0 View commit details
    Browse the repository at this point in the history

  5. fix some none portable code that was using GCC impl details

    @Ryex
    Ryex committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    18fdffd View commit details
    Browse the repository at this point in the history

  6. - pulling in std::back_insterter under MSVC 

    - MSVC needs a return value even with unreachable code
    @Ryex
    Ryex committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    461f9ab View commit details
    Browse the repository at this point in the history

  7. cleanup of CMakeLists.txt 

    properly deal with extraldflags

Signed-off-by: Rachel Powers <[email protected]>
    @Ryex
    Ryex committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    7567723 View commit details
    Browse the repository at this point in the history

  8. better windows header and symbol detection

    @Ryex
    Ryex committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    1bac2fa View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. use check_cxx_symbol_exists to get better detection 

    Signed-off-by: Rachel Powers <[email protected]>
    @Ryex
    Ryex committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    f6d6fa6 View commit details
    Browse the repository at this point in the history

  2. ensure better checkes still pass on MSVC 

    checking for c functions with check_cxx_* can cause check to fail do to overloads
    @Ryex
    Ryex committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    7f7cdab View commit details
    Browse the repository at this point in the history

  3. we really need these to be lists but wiht the simi-colons seperated b… 

    …acking
    @Ryex
    Ryex committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    b0aa8a3 View commit details
    Browse the repository at this point in the history

  4. fix typo

    @Ryex
    Ryex committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    fe4d34f View commit details
    Browse the repository at this point in the history

  5. print when searching for windows TLS libs

    @Ryex
    Ryex committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    f3e7e9c View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. respect WITH_<OPTION> directives 

    add static lib target

Signed-off-by: Rachel Powers <[email protected]>
    @Ryex
    Ryex committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    9b82f9f View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2023

  1. fix: properly set static lib include dirs 

    Signed-off-by: Rachel Powers <[email protected]>
    @Ryex
    Ryex committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    595ecd9 View commit details
    Browse the repository at this point in the history

  2. fix: prevent masking of SIZE_MAX on msvc 

    fix: set proper include dirs for static target
fix: cache all needed build vars so that a reconfig doesn't lose them
    @Ryex
    Ryex committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    fff9932 View commit details
    Browse the repository at this point in the history