Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few improvements to the docker-based Windows builds
Use
docker build --build-arg GIT_TAG=<tag> ...
Use
docker build --build-arg GITHUB_REPO=nyurik/aria2 ...
Use
docker build --build-arg SOURCE=local ...
Use
docker build --build-arg LIBARIA2=enable ...
Use
docker build --build-arg ARIA2_STATIC=no ...
Use
docker build --build-arg HOST=x86_64-w64-mingw32 ...
aria2.exe
to the shared volume/output
if it is provided.This is significantly simpler than copying from a running container.
Running
docker run --rm -v $PWD:/output aria2-mingw
will placearia2.exe
into$PWD/bin
directory. Additionally, ifLIBARIA2=enable
, libs will be copied to$PWD/lib
, andaria2.h
will be saved to$PWD/include/aria2/aria2.h
.This PR can be tested directly from bash without cloning: