Fix a wait in the retry for HTTP 404 error #1714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If HTTP 404 error is hit then aria2 retries max-file-not-found times to download but without to wait retry-wait seconds (as in the case of the HTTP 503, for example). There was such an error before and it was fixed but partially only (the fix raises the exception DL_RETRY_EX2 but it does not start a waiting itself). The fix added a waiting, together with HTTP_SERVICE_UNAVAILABLE error (HTTP 503).
Also the fix adds logging of it under the DEBUG severity.