This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Add a compareCommit param when creating build
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavier-villelegier
changed the title
compareCommit param when creating buildcompareCommit param when creating build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey !
We'd like to compare to the
merge-baseinstead of the baselineBranch, to avoid having argos screenshots diffs that don't belong to your PR but were merged in the baselineBranch the meantime.As the Github API doesn't provide a way to get the
merge-base(issue opened on the github community here) we can't do this directly in argos using Octokit, so we need to find a way to send it as a param to argos.I think this might be the optimal way as it also allows to compare to basically anything if needed